Skip to content

Cases in broadcasting columns#324

Open
jishnub wants to merge 1 commit intoJuliaLinearAlgebra:masterfrom
jishnub:colbcast
Open

Cases in broadcasting columns#324
jishnub wants to merge 1 commit intoJuliaLinearAlgebra:masterfrom
jishnub:colbcast

Conversation

@jishnub
Copy link
Copy Markdown
Member

@jishnub jishnub commented Feb 15, 2023

Using arrays

julia> B = brand(5000,5000,0,0); v = rand(size(B,1)); B2 = brand(5000,5000,2,2);

we obtain

Operation Master PR
B .* v 32.329 μs 28.289 μs
v .* B 38.244 μs 30.009 μs
B2 .* v 61.873 μs 59.356 μs
v .* B2 83.148 μs 72.213 μs

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 15, 2023

Codecov Report

❌ Patch coverage is 50.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.84%. Comparing base (bcedda1) to head (5752977).
⚠️ Report is 172 commits behind head on master.

Files with missing lines Patch % Lines
src/generic/broadcast.jl 50.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   82.08%   81.84%   -0.24%     
==========================================
  Files          24       24              
  Lines        3321     3333      +12     
==========================================
+ Hits         2726     2728       +2     
- Misses        595      605      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub
Copy link
Copy Markdown
Member Author

jishnub commented Feb 15, 2023

I can't really think of tests for the non-standard branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant