Add GraphsMatching NX backend extension for minimum_weight_perfect_matching#6
Open
AJ0070 wants to merge 2 commits intoJuliaGraphs:mainfrom
Open
Add GraphsMatching NX backend extension for minimum_weight_perfect_matching#6AJ0070 wants to merge 2 commits intoJuliaGraphs:mainfrom
AJ0070 wants to merge 2 commits intoJuliaGraphs:mainfrom
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Member
Author
|
@Krastanov code-style is failing due to other files unrelated to this. I will fix it in other PR after this is merged. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional
GraphsMatching.jlintegration forminimum_weight_perfect_matching(g, weights, NXAlgorithm()).Changes
GraphsMatchingas a weak dependencyext/NetworkXGraphsGraphsMatchingExt.jlNXAlgorithmmarker type to the base packageGraphsMatching.minimum_weight_perfect_matching(..., NXAlgorithm())for plain
Graphs.jlinput and wrappedNetworkXGraphinputGraphs.jlgraph inputNetworkXGraphinputMatchingResultcompatibilityNote
This backend is implemented because the semantics are close enough for exact use:
NetworkX’s matching backend is exact for integer weights, and
GraphsMatchingalready rescales floating-point weights to integers before solving. The extension
also checks that the returned matching is perfect before building the
MatchingResult.AI Disclosure: I used Codex 5.3. I used it initially to provide me skeleton structure for the code following the directory structure, make test to get successful coverage of changes, debugging the failures(e.g. compilation and test failures), update Readme with respect to my changes and also asked it to verify my implementation if there are any bugs or gaps exists. also used chatgpt to format my PR description in markdown.