Define jl_get_pgcstack_resolved in the native test loader. - #916
Merged
Conversation
Since JuliaLang/julia#61527, Julia's LowerPTLS pass no longer bakes the address of the TLS getter into generated code on platforms without a static TLS offset (macOS, Windows), but emits a call to an external `jl_get_pgcstack_resolved` that Julia's own JIT defines through `add_named_global`. That symbol is not exported from libjulia, so the process-symbol generator used by `Native.load` cannot resolve it, and loading Julia-runtime-backed code (the `runtime-backed boxed constants` test added in #913) fails with `Symbols not found`. Mirror what Julia's JIT does: look up the getter with `jl_pgcstack_getkey` and define it as an absolute symbol in the JITDylib. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merged
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #916 +/- ##
=======================================
Coverage 84.56% 84.56%
=======================================
Files 29 29
Lines 5546 5546
=======================================
Hits 4690 4690
Misses 856 856 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since JuliaLang/julia#61527, Julia's LowerPTLS pass no longer bakes the address of the TLS getter into generated code on platforms without a static TLS offset (macOS, Windows), but emits a call to an external
jl_get_pgcstack_resolvedthat Julia's own JIT defines throughadd_named_global. That symbol is not exported from libjulia, so the process-symbol generator used byNative.loadcannot resolve it, and loading Julia-runtime-backed code (theruntime-backed boxed constantstest added in #913) fails withSymbols not found.Mirror what Julia's JIT does: look up the getter with
jl_pgcstack_getkeyand define it as an absolute symbol in the JITDylib.