Skip to content

Adding support for loggers#74

Merged
ablaom merged 2 commits into
JuliaAI:devfrom
pebeto:dev
May 12, 2026
Merged

Adding support for loggers#74
ablaom merged 2 commits into
JuliaAI:devfrom
pebeto:dev

Conversation

@pebeto

@pebeto pebeto commented Apr 17, 2026

Copy link
Copy Markdown
Member

For #65.

Adds a logger keyword argument to IteratedModel, following the same pattern used in MLJTuning.jl.

  • Added logger::L field to DeterministicIteratedModel and ProbabilisticIteratedModel
  • IteratedModel constructor accepts logger=default_logger() keyword

ablaom
ablaom approved these changes May 12, 2026
View reviewed changes

@ablaom ablaom left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pebeto for this valuable contribution. Tested locally just now, very cool.

The comprehensive testing is great to have.

@ablaom ablaom merged commit 122b71f into JuliaAI:dev May 12, 2026
2 checks passed
This was referenced May 12, 2026
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ablaom ablaom ablaom approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pebeto @ablaom