Repository navigation
fix(prompt): respect JsonClassDiscriminator in JSON schemas - #2237
Open
Shanto Islam (shanthropic) wants to merge 1 commit into
Open
Shanto Islam (shanthropic) wants to merge 1 commit into
Shanto Islam (shanthropic) wants to merge 1 commit into
Conversation
Resolve the discriminator from the polymorphic base descriptor before falling back to the Json configuration. Add regression coverage for sealed and open hierarchies, configured fallback, and discriminator modes. Refs JetBrains#2105
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StandardJsonSchemaGeneratoralways used the discriminator from theJsonconfiguration, even when the polymorphic base type had a@JsonClassDiscriminatorannotation. This could produce a schema that did not match the JSON generated by Kotlin serialization.Use the discriminator declared on the polymorphic descriptor when present, while retaining the configured discriminator as the fallback.
Add regression tests covering annotated sealed and open hierarchies, unannotated types,
ALL_JSON_OBJECTS, and disabled class discriminators.Tested with:
:prompt:prompt-structure:jvmTest:prompt:prompt-structure:jsTest:prompt:prompt-structure:build:prompt:prompt-structure:ktlintCheckcloses #2105