Implement JVM GC management to reduce measurement noise (issue #134)#142
Closed
Implement JVM GC management to reduce measurement noise (issue #134)#142
Conversation
…ing benchmarks Co-authored-by: jamesmarkchan <6020424+jamesmarkchan@users.noreply.github.com>
…gitignore Co-authored-by: jamesmarkchan <6020424+jamesmarkchan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with incorrect disk speed reporting
Implement JVM GC management to reduce measurement noise (issue #134)
Feb 26, 2026
Member
|
PR #143 looks more through so will use that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GC pauses introduce noise spikes into sample measurements. This adds two mitigations: pre-benchmark GC triggering to drain heap pressure before I/O starts, and per-sample GC detection with automatic retake on detection.
New:
GcManagerUtility class backed by the standard
ManagementFactory.getGarbageCollectorMXBeans()API (no internal APIs):triggerPreBenchmarkGc()— callsSystem.gc()before benchmark execution beginsgetTotalGcCount()/gcOccurredSince(snapshot)— lightweight GC event detection via collection count deltaBenchmarkRunnerchangesexecute(): callsGcManager.triggerPreBenchmarkGc()afterrecordStartTime(), before any I/O phaserunOperation(): wraps each sample in a do-while retry loop; on GC detection, undoes the per-block progress counter increments (viaLongAdder.add(-numBlocks)) and retakes the sample up toMAX_GC_RETRIES = 3times, logging each retake with retry index🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.