Repository navigation
Conversation
…SDK initialization and logging
…ions and usage examples
6 new issues
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
…lure' into MOB-12231-refactor-classes-to-reduce-circular-dependencies
…lure' into MOB-12231-refactor-classes-to-reduce-circular-dependencies
…rectly in relevant classes
|
|
Diff Coverage: The code coverage on the diff in this pull request is 82.4%. Total Coverage: This PR will increase coverage by 3.98%. File Coverage Changes
🛟 Help
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
lposen
marked this pull request as ready for review
October 9, 2025 19:23
Ayyanchira
self-requested a review
October 9, 2025 22:31
Ayyanchira
reviewed
Oct 9, 2025
| "prepare": "yarn build", | ||
| "release": "release-it" | ||
| "release": "release-it", | ||
| "circ": "npx madge --circular --extensions ts ./" |
Member
There was a problem hiding this comment.
Is it a dedicated package to results circular dependency?
| @@ -23,9 +21,14 @@ import type { IterableCommerceItem } from './IterableCommerceItem'; | |||
| import { IterableConfig } from './IterableConfig'; | |||
| import { IterableLogger } from './IterableLogger'; | |||
| import type { IterableAuthFailure } from '../types/IterableAuthFailure'; | |||
Member
There was a problem hiding this comment.
Import 'type' is removed above. Is this one ok?
Contributor
Author
There was a problem hiding this comment.
Yes. The issue was coming from the use of Iterable.logger in IterableInAppManager. This has been changed to not require that anymore.
|
|
||
| const RNEventEmitter = new NativeEventEmitter(RNIterableAPI); | ||
|
|
||
| const defaultConfig = new IterableConfig(); |
Member
There was a problem hiding this comment.
Not sure how default implementation comes into play. Any possibility of regression?
Contributor
Author
There was a problem hiding this comment.
No -- it's the same functionality as was there before -- it's just assigning it to a variable
…gging behavior and hierarchy
…sses' into jwt/MOB-10947-task-3-android-retrypolicy-config-at-android-br
…oid-br' into MOB-12231-refactor-classes-to-reduce-circular-dependencies
…thManager from Iterable class
Comment on lines
+45
to
+49
| static initialize2WithApiKey( | ||
| apiKey: string, | ||
| config: IterableConfig = new IterableConfig(), | ||
| version: string, | ||
| apiEndPoint: string |
Comment on lines
+163
to
+168
| static trackPushOpenWithCampaignId( | ||
| campaignId: number, | ||
| templateId: number, | ||
| messageId: string | null | undefined, | ||
| appAlreadyRunning: boolean, | ||
| dataFields?: unknown |
Comment on lines
+253
to
+257
| static trackInAppClose( | ||
| message: IterableInAppMessage, | ||
| location: IterableInAppLocation, | ||
| source: IterableInAppCloseSource, | ||
| clickedUrl?: string |
Comment on lines
+512
to
+518
| static updateSubscriptions( | ||
| emailListIds: number[] | null, | ||
| unsubscribedChannelIds: number[] | null, | ||
| unsubscribedMessageTypeIds: number[] | null, | ||
| subscribedMessageTypeIds: number[] | null, | ||
| campaignId: number, | ||
| templateId: number |
jferrao-itrbl
deleted the
MOB-12231-refactor-classes-to-reduce-circular-dependencies
branch
September 15, 2026 06:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔹 JIRA Ticket(s) if any
✏️ Description