BUG: VTK Bridge publicly depends on ITKCommon#5852
Merged
blowekamp merged 1 commit intoInsightSoftwareConsortium:mainfrom Mar 2, 2026
Merged
BUG: VTK Bridge publicly depends on ITKCommon#5852blowekamp merged 1 commit intoInsightSoftwareConsortium:mainfrom
blowekamp merged 1 commit intoInsightSoftwareConsortium:mainfrom
Conversation
Changes VTK Bridge module dependency from PRIVATE_DEPENDS to DEPENDS for ITKCommon, making it a public dependency as required. Related to PR InsightSoftwareConsortium#5842
github-actions
bot
added
type:Bug
dzenanz
approved these changes
Mar 2, 2026
Member
|
/azp run ITK.Windows |
blowekamp
merged commit a3a8973
into
InsightSoftwareConsortium:main
17 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes VTK Bridge module dependency from PRIVATE_DEPENDS to DEPENDS for ITKCommon, making it a public dependency as required.
The VTK Bridge module's headers include ITKCommon headers, which means ITKCommon must be a public dependency, not a private one. This ensures that consuming the ITKVTK module properly propagates the ITKCommon dependency.
Related to PR #5842
Changes:
Modules/Bridge/VTK/itk-module.cmaketo changePRIVATE_DEPENDStoDEPENDSfor ITKCommon