STYLE: Remove ImageRegionConstIteratorWithIndex from OpenCVVideoCapture#5847
Open
N-Dekker wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Conversation
The declared local iterator variable `itkIter` appears unused.
github-actions
bot
added
area:Video
dzenanz
approved these changes
Mar 1, 2026
N-Dekker
commented
Mar 1, 2026
Member
|
ITK.macOS.Python failed due to some timeout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The declared local iterator variable
itkIterappears unused.This local variable was introduced with commit 48aba9a (9 May 2011), but even then, it was unused:
ITK/Modules/VideoIO/OpenCV/include/itkOpenCVVideoCapture.txx
Lines 152 to 153 in 48aba9a
@gabehart Do you possibly still have a clue why the variable was introduced in the first place? I hope you agree with its removal, as hereby proposed!