Conversation
… remove points ahead of the tip
…on edge direction
…sts to edge element types
…ing points vector
th-skam
added
pr: enhancement
pr: status to review
epernod
approved these changes
Sep 12, 2025
epernod
added
pr: status ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #85
A new operation is added in the
Operations::Needlenamespace. It carries out the task of removing coupling points during the needle retraction phase.The reasoning behind these PRs is to separate the algorithm logic from independent operations, specific to the geometry of the needle and tissue. This helps declutter the
InsertionAlgorithm; theGenericOperationwraps the required dynamic casts when dealing with theEdgeGeometryof the needle object.Close #86