test(torch): skip high-memory cuda svd reference#628
Draft
zhangyue207 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
svdgenerated torch-op case for the generic(4, 4, 5632)shape before calling the PyTorch reference.Motivation
NVIDIA CI repeatedly failed in unrelated upstream PRs because the PyTorch
svdreference path for(4, 4, 5632)consumed about 72 GiB on 80 GiB runners, leaving too little memory for the remaining pytest workers and causing CUDA OOM. The InfiniOps wrapper is not being exercised meaningfully in that case because the reference path itself is the unstable part.Closes N/A
Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Test Results on Supported Platforms
pytestResulttests/test_torch_ops.py::test_op[...,4x4x5632-svd].ruff format --check,ruff check, andgit diff --checkpassed.Full `pytest` output (optional)
Benchmark / Performance Impact
N/A
Notes for Reviewers
cuda,svd, and shape(4, 4, 5632).Checklist
Title, Branch, and Commits
feat(nvidia): …,fix(cuda/gemm): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene (applies to all languages)
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).C++ Specific (if C++ files changed)
Python Specific (if Python files changed)
ruff format --checkpassed for touched Python files.ruff checkpassed for touched Python files.Testing
tests/. This PR updates an existing generated test harness skip condition.pytest.mark.auto_act_and_assert. No operator test was added.dtype/deviceparameterization. No parameterization was changed.Build, CI, and Tooling
compile_commands.json. This PR does not change CMake configuration.Documentation
Security and Safety