feat: Add convenience formatting caption methods.#741
Open
NFRCG wants to merge 1 commit intoIncendo:masterfrom
Open
feat: Add convenience formatting caption methods.#741NFRCG wants to merge 1 commit intoIncendo:masterfrom
NFRCG wants to merge 1 commit intoIncendo:masterfrom
Conversation
Member
|
not sure about this one, you could just do this yourself by getting the CaptionFormatter / CaptionRegistry from the CommandManager. If you still think there's a good reason change this pr a little so that the old methods call this method and supply this.commandSender |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR adds convenience methods to allow caption formatting from the CommandContext for a different recipient that is not the command sender.
The benefit of this is to allow usage of the same mechanisms for formatting/sending captions for the sender AND the recipient of a command.
If there is an alternative or preferred way to achieve the same goal, please let me know and I'll close this PR.