Open
Conversation
sagarreddypatil
requested changes
Oct 5, 2020
Contributor
sagarreddypatil
left a comment
There was a problem hiding this comment.
Still need to do the following things
- Add option to change the properties of any object by clicking on it
- All objects should have the option to change static and dynamic friction
- Dynamic objects(such as the cube) should have the option to change the mass, in addition to static and dynamic friction
- Give the scenes simpler names. "Physics Basic Simulation InVisionAR" can be changed to "Basic Physics Simulation"
- Use a plane instead of the terrain object.
- Organize all assets into their respective folders(Physic materials go to the Physic Materials folder, etc.)
- Delete all unnecessary assets(NewLayer, Terrain, anything that isn't being used.
I don't get why you still haven't done the object editing yet. That is one of the basic requirements for this task.
Contributor
|
Also, there was literally absolutely no reason to close the pull request. Please don't close a PR unless you are told to do so. |
Author
|
Sorry about that. Also, just to make it clear for you, I did have a section for the physics material where you can edit the mass, static friction. etc. if you click on the object and click the respective physics material to change it. Also, I have updated these values already with the recent push so please check that. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2