fix(preview): decouple database contract gate - #69
Merged
Conversation
xiaoland
marked this pull request as ready for review
August 13, 2026 09:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Database contractjobWorkspace contractindependently verify/build the Client and upload exact Web/MF artifactsWorkspace contractjob passed and itsclient-web-distartifact is liveClient checksworkflowWhy
Previewability and merge compatibility are different states. A Client PR that intentionally depends on an unmerged Core database contract can be valid to build and preview even though it is not yet compatible with stable Core and must not merge.
The old topology put type generation before the workspace build in one job. A stale stable-Core contract therefore prevented artifact creation, and
Pages previewrequired the entire workflow to succeed. This made cross-repository feature review self-blocking.Security and delivery boundary
Workspace contractjob must be completed successfully in the same workflow runclient-web-distartifactsuccessDatabase contractremains a required merge check; branch protection must add this new context when this PR is admittedVerification
pnpm check— 18 files / 78 tests, all type checks and builds passedgo run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12 .github/workflows/*.ymlgit diff --checkRollout
This workflow PR must land before #68 can benefit from the new preview topology. On admission, update
mainprotection to requireDatabase contractalongside the existing checks, then sync #68 withmainand rerunClient checks.