Draft
Conversation
It's purpose is to automatically cast non-text values to text if the used filter is a `LIKE`. Though, I don't *like* this. But it's the only solution right now. It depends highly on the maintained column type. While this isn't that bad, since *I* believe there are more text columns than other types (so maintaining them isn't that difficult), but currentlyl there's no default type. So if the type is not maintained, it currently casts everything to text, even if not necessary. But is it a good idea to have the type default to text? This needs to be addressed. Also, is there an alternative implementation? Another bad thing is that each model has to provide it explicitly. This should be a default behavior somehow if you ask me. If you have several models seeing this everywhere makes you wonder: ``` $behaviors->add(new NonTextMatch()); ```
Member
Author
|
Oh, and it's here because there's the |
Member
Author
|
And another problem that comes to my mind right now: What about the filter optimizations? We add |
This was referenced Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's purpose is to automatically cast non-text values
to text if the used filter is a
LIKE.Though, I don't like this. But it's the only solution
right now. It depends highly on the maintained column
type. While this isn't that bad, since I believe there
are more text columns than other types (so maintaining them
isn't that difficult), but currentlyl there's no default
type. So if the type is not maintained, it currently casts
everything to text, even if not necessary. But is it a good
idea to have the type default to text?
This needs to be addressed.
Also, is there an alternative implementation? Another bad
thing is that each model has to provide it explicitly. This
should be a default behavior somehow if you ask me. If you
have several models seeing this everywhere makes you wonder:
requires #70