Indexing Simplifications #12093
Open
Indexing Simplifications #12093
+223
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR provides a simpler mechanism to get the versions to index relative to the logic in getDesiredCards(). It also drops a ~duplicate method for getting the desired versions (one was used for content indexing, the other for permissions) and adds a unit test to verify that new code retrieves the expected versions in various cases.
Which issue(s) this PR closes:
Special notes for your reviewer: This is built on #12082 which will hopefully be merged soon. It may be easier to look at the two commits if you review before that PR merges.
Suggestions on how to test this: Regression-only - should not change any functionality.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: