Radio - Replace inventory PFH with CBA loadout handler

[Freddo3000]

When merged this pull request will:

• Change inventory monitoring PFH to instead use CBA loadout player eventhandler
• Add setting for setting the replacement radio Radio - Add radio item replacement CBA Setting #1283
• Add option for simply removing the radio instead without replacement Radio - Add radio item replacement CBA Setting #1283

Tested in vanilla arsenal

[PabstMirror]

maybe make a note in acre_api_fnc_setItemRadioReplacement that it's use is deprecated
I think manually changing variables that are cba_settings isn't good

[jonpas]

Does this interfere with Basic Mission Setup module? This particular functionality of it is broken atm (ref. #574), but we should still think about it.

[Sniperhid]

So one of the complexities of moving away from PFH is ACRE_HOLD_OFF_ITEMRADIO_CHECK. I haven't tested it but I don't think your code currently covers this case.

This exists because when right clicking radios on the ground (also crate/other person's inventory etc) they would typically take the assigned item slot. This is less of an issue now that radios inherit from a misc item so they can't go there except ItemRadio. This remains because it's possible to dislodge ItemRadioAcreFlagged which sits in the assigned item slot (to ensure vanilla radio functionality continues). So what the code currently does is on opening inventory is set ACRE_HOLD_OFF_ITEMRADIO_CHECK = true then false after closing the inventory.

So a test case for this is ensuring ItemRadioAcreFlagged remains in the assigned item slot when right clicking on a ItemRadio from a groundholder/weapons crate etc., and that ItemRadioAcreFlagged doesn't exist elsewhere in the inventory.

[jonpas]

How does this work in combination with Basic Setup module? I think default radios in the module are kind of broken currently anyways.

[jonpas]

How does this work in combination with Basic Setup module? I think default radios in the module are kind of broken currently anyways.

This question remains and should be looked at. It kind of partly replaces that part of the module as far as I understand.

---

@Sniperhid can you look at recent changes regarding replacement of PFH with EH?

[Freddo3000]

Just as a heads up I haven't tested the last few commits in game

[jonpas]

Leaving a note here: We have to think about API for this, copy-pasting those lines is far from ideal.

[jonpas]

Will probably take a look at finishing this for 2.10.0.

[jonpas]

This is almost done, but I don't want to risk it release in v2.11.0, will be part of dev-build after though.

[jonpas]

Add setting for setting the replacement radio
Add option for simply removing the radio instead without replacement

Split that off into #1283 so we can merge the important part and leave below for further testing.

Change inventory monitoring PFH to instead use CBA loadout player eventhandler

As noted in a comment above, problem is we are potentially not catching all cases of radio replacement with the handler. If we need a special call to handle it for Arsenal, then who knows how many 3rd party systems would need to do the same - that's not reliable. System needs to catch it all without a new API requiring this. PFH as it is shouldn't be expensive in most cases anyways.