Skip to content

fix: allow empty-string JSON keys when checking duplicate keys#796

Open
SergioChan wants to merge 1 commit intoIBM:mainfrom
SergioChan:fix-issue-513-empty-string-key
Open

fix: allow empty-string JSON keys when checking duplicate keys#796
SergioChan wants to merge 1 commit intoIBM:mainfrom
SergioChan:fix-issue-513-empty-string-key

Conversation

@SergioChan
Copy link

@SergioChan SergioChan commented Mar 6, 2026

Summary

  • avoid rejecting valid JSON files that use an empty string ("") object key
  • keep duplicate-key protection in place, but ignore the known false-positive parser error (Syntax error: empty string near)
  • add a regression test fixture and CLI test coverage for this case

Testing

  • npx jest test/cli-validator/tests/error-handling.test.js --runInBand (from packages/validator)

Related

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2026

CLA assistant check
All committers have signed the CLA.

@SergioChan
Copy link
Author

Thanks for the check. I’ll rewrite the branch with signed-off commits so the DCO gate passes, then push an updated commit set.

@SergioChan SergioChan force-pushed the fix-issue-513-empty-string-key branch from fca4c65 to 5d4e278 Compare March 7, 2026 07:02
@SergioChan
Copy link
Author

Update pushed ✅ I rebased the branch with --signoff and force-pushed, so all commits now carry Signed-off-by lines for DCO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Syntax error: empty string near e": {"": "

2 participants