fix: adding the smtp config id for metrics api#70
Open
harini-ibm wants to merge 1 commit into
Open
Conversation
nitish-sudo
reviewed
Jun 18, 2026
| .destinationType("smtp_custom") | ||
| .gte("2025-12-08T17:18:43Z") | ||
| .lte("2025-12-09T11:55:22Z") | ||
| .smtpConfigId(smtpConfigID) |
Contributor
There was a problem hiding this comment.
why smtpConfigId is required here? for smtp_custom type
nitish-sudo
reviewed
Jun 18, 2026
| .gte("2024-08-01T17:18:43Z") | ||
| .lte("2024-08-02T11:55:22Z") | ||
| .smtpConfigId(smtpConfigID) | ||
| .destinationId(destinationId16) |
Contributor
There was a problem hiding this comment.
destinationId is not required in case of smtpConfigId. check once
nitish-sudo
reviewed
Jun 18, 2026
| .smtpConfigId(smtpConfigID) | ||
| .gte(instant.minus(Duration.ofDays(1)).toString()) | ||
| .lte(d1) | ||
| .destinationId(destinationId16) |
Contributor
There was a problem hiding this comment.
is destinationId required in case of smtpConfigId
nitish-sudo
requested changes
Jun 18, 2026
nitish-sudo
left a comment
nitish-sudo
left a comment
Contributor
There was a problem hiding this comment.
Requesting the changes
harini-ibm
force-pushed
the
metrics
branch
2 times, most recently
from
e17c134 to
2224b69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes: https://github.ibm.com/Notification-Hub/planning/issues/19982
PR Checklist
Please make sure that your PR fulfills the following requirements:
PR Type
What is the current behavior?
For the GET /metrics API current documentation states that destination_type is a mandatory parameter for retrieving metrics. However, this is not accurate, as metrics can be retrieved without always providing destination_type.
What is the new behavior?
For the GET /metrics API, users can provide either destination_type or smtp_config_id to retrieve metrics. Supplying both parameters is not required.
Does this PR introduce a breaking change?
Other information