fix(ray_tune): process_metric not handling virtual properties correctly#663
Closed
michael-johnston wants to merge 2 commits intomainfrom
Closed
fix(ray_tune): process_metric not handling virtual properties correctly#663michael-johnston wants to merge 2 commits intomainfrom
michael-johnston wants to merge 2 commits intomainfrom
Conversation
The code assumed the entity contained the just measured property values, and hence it could be used to do the aggregation - however this was not the case. At some stage the code was changed to work directly with the MeasurementRequests and updating this piece was missed.
Member
Author
|
@AlessandroPomponio Update the tests re: mocks. |
Member
Author
|
Merged this with #668 and closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code assumed the entity contained the just measured property values, and hence it could be used to do the aggregation - however this was not the case.
At some stage the code was changed to work directly with the MeasurementRequests and updating this piece was missed.