Improve TSV breakpoint suggestionsImprove TSV breakpoint suggestions - #36
Improve TSV breakpoint suggestionsImprove TSV breakpoint suggestions#36manav252 wants to merge 2 commits into
Conversation
|
Thank you for the PR. Could you add integration tests and example files that test the behavior for the three possible cases? Additionally, the speed with which you provided this fix suggests that you are either an AI agent yourself or used generative AI to create this code. Issues tagged as good first issues are intended to provide human contributors an easy entry into this project. Please do not provide AI generated code for such issues in the future. |
Thanks for the feedback. I added integration coverage and example TSV files for the three malformed breakpoint cases:
I also added a small guard so the CLI reports the breakpoint suggestion instead of continuing into parsing after invalid breakpoint detection. Validation:
Also, I understand your concern about good first issues. I did use AI assistance on this contribution, and I should have been more mindful that good first issues are intended for human newcomers. I will avoid submitting AI-generated code to good-first-issue tagged issues in this project in the future. |
Summary
suggestions.pyhelper from TSV input parsing.Validation
PYTHONPATH=. pytest tests/unit_tests.py tests/integration_tests.py -qblack --check --verbose yml2block/Addresses #35.