Skip to content

Improve TSV breakpoint suggestionsImprove TSV breakpoint suggestions - #36

Open
manav252 wants to merge 2 commits into
HenningTimm:mainfrom
manav252:fix-tsv-breakpoint-suggestions
Open

Improve TSV breakpoint suggestionsImprove TSV breakpoint suggestions#36
manav252 wants to merge 2 commits into
HenningTimm:mainfrom
manav252:fix-tsv-breakpoint-suggestions

Conversation

@manav252

@manav252 manav252 commented Jul 3, 2026

Copy link
Copy Markdown

Summary

  • Add actionable suggestions for invalid TSV breakpoint detection.
  • Explain when no block headers, only one block header, or too many block headers are found.
  • Reuse the existing suggestions.py helper from TSV input parsing.
  • Add unit assertions for the new suggestion messages.

Validation

  • PYTHONPATH=. pytest tests/unit_tests.py tests/integration_tests.py -q
  • black --check --verbose yml2block/

Addresses #35.

@HenningTimm

Copy link
Copy Markdown
Owner

Thank you for the PR. Could you add integration tests and example files that test the behavior for the three possible cases?

Additionally, the speed with which you provided this fix suggests that you are either an AI agent yourself or used generative AI to create this code. Issues tagged as good first issues are intended to provide human contributors an easy entry into this project. Please do not provide AI generated code for such issues in the future.

@manav252

manav252 commented Jul 3, 2026

Copy link
Copy Markdown
Author

Thank you for the PR. Could you add integration tests and example files that test the behavior for the three possible cases?

Additionally, the speed with which you provided this fix suggests that you are either an AI agent yourself or used generative AI to create this code. Issues tagged as good first issues are intended to provide human contributors an easy entry into this project. Please do not provide AI generated code for such issues in the future.

Thanks for the feedback. I added integration coverage and example TSV files for the three malformed breakpoint cases:

  • no block headers
  • one block header
  • too many block headers

I also added a small guard so the CLI reports the breakpoint suggestion instead of continuing into parsing after invalid breakpoint detection.

Validation:

  • PYTHONPATH=. pytest tests/unit_tests.py tests/integration_tests.py -q
  • black --check --verbose yml2block/

Also, I understand your concern about good first issues. I did use AI assistance on this contribution, and I should have been more mindful that good first issues are intended for human newcomers. I will avoid submitting AI-generated code to good-first-issue tagged issues in this project in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants