Skip to content

Feature: pet chip (RND-1824)#2910

Open
panasetskaya wants to merge 41 commits intodevelopfrom
feat/pet-chip-id
Open

Feature: pet chip (RND-1824)#2910
panasetskaya wants to merge 41 commits intodevelopfrom
feat/pet-chip-id

Conversation

@panasetskaya
Copy link
Copy Markdown
Contributor

@panasetskaya panasetskaya commented Mar 30, 2026

  • check for accessibility
  • translations
  • publ schema to prod
  • BE not merged yet

@panasetskaya panasetskaya requested a review from a team as a code owner March 30, 2026 15:34
@panasetskaya panasetskaya changed the title Feature: pet chip Feature: pet chip (RND-1824) Mar 30, 2026
@notion-workspace
Copy link
Copy Markdown

🐕 ChipID for pets

Comment on lines +221 to +223
val digitsOnlyTransformation = InputTransformation.byValue { _, proposed ->
proposed.filter { it.isDigit() }
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would be worth it for us to create a DigitsOnly InputTransformation just like some exist in the library itself https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/input/InputTransformation.kt;l=213-227?q=MaxLengthFilter which would also determine the KeyboardType.Number inside there so wherever we use it it's already properly preconfigured?
And have it live in design-system perhaps

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with another transformation in the end, the visual mask like we do for ssn input:)

Comment on lines +4 to +9
<issue
id="UnknownIssueId"
message="Unknown issue id &quot;androidx.media3.common.util.UnstableApi&quot;">
<location
file="build.gradle.kts"/>
</issue>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really wonder why this is messed up as it is here 🙈😭

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:elmofire:

panasetskaya and others added 15 commits April 2, 2026 10:16
# Conflicts:
#	app/core/core-resources/src/androidMain/res/values-sv-rSE/strings.xml
#	app/core/core-resources/src/androidMain/res/values/strings.xml
#	app/core/core-resources/src/commonMain/composeResources/values-sv-rSE/strings.xml
#	app/core/core-resources/src/commonMain/composeResources/values/strings.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants