-
Notifications
You must be signed in to change notification settings - Fork 214
add c_standard/cpp_standard xml attributes. #1301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add c_standard/cpp_standard xml attributes. #1301
Conversation
6b544de to
f100081
Compare
f100081 to
8147022
Compare
8147022 to
48f0cc4
Compare
tobil4sk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (inFile.mCStandard != null) { | ||
| if (BuildTool.isMsvc()) { | ||
| if (inFile.mCStandard > 17) { | ||
| args.push('/std:clatest'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now hardcoded rather than being configurable by xml. Maybe the compiler can have something like <stdflag value="/std:" />.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making this properly configurable (in a way that does not require special casing in the build tool) would be more complex than what you're suggesting, and I don't think that's worth doing right now.
|
|
||
| <set name="HXCPP_CPP11" value="1" /> | ||
| <set name="OBJDBG" value="-dbg" if="debug" /> | ||
| <set name="OBJDBG" vlue="-dbg" if="debug" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed!
No description provided.