Skip to content

Revert "Remove redundant music checks in frontend methods" - #3636

Merged
Geokureli merged 7 commits into
devfrom
revert-3586-music-focus
Jul 19, 2026
Merged

Revert "Remove redundant music checks in frontend methods"#3636
Geokureli merged 7 commits into
devfrom
revert-3586-music-focus

Conversation

@Geokureli

@Geokureli Geokureli commented Jul 16, 2026

Copy link
Copy Markdown
Member

Reverts #3586

This is a breaking change. It breaks any project that manually replaces FlxG.sound.music, most notably Funkin'.

From what I've gathered, FlxG.sound.music used to be updated independently of the sound list. If you wanted to replace it with a custom sound you could simply reassign it (and remove it from the sound list, if created via FlxG.sound). (example)

Since it's no longer updated independently, projects that do the aforementioned now have music that doesn't update, which is especially problematic in FNF's case as the sound time no longer updates, and therefore the gameplay gets stuck

@Geokureli Geokureli added this to the 6.2.0 milestone Jul 16, 2026
@moxie-coder

Copy link
Copy Markdown
Contributor

I'm guessing this broke something?

@ACrazyTown

Copy link
Copy Markdown
Contributor

I'm guessing this broke something?

#3586 (comment)

@Geokureli
Geokureli merged commit 3153fa9 into dev Jul 19, 2026
10 checks passed
@Geokureli
Geokureli deleted the revert-3586-music-focus branch July 19, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants