Repository navigation
Improved routing on the client side - #419
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The routing and notification-link changes are consistent, focused, and covered by relevant backend assertions.
0 open findings
What changed in this PR
Improves client routing with canonical home and profile-tab URLs, including direct Slack links.
Changes:
- Makes
/the home route and redirects legacy/unknown routes there. - Stores active profile tabs in URLs.
- Deep-links Slack notifications to relevant tabs.
| File | Description |
|---|---|
client/src/routes/routes.tsx |
Updates home and profile routes. |
client/src/hooks/useProfileTab.ts |
Adds URL-backed tab navigation. |
client/src/layout/Sidebar/SidebarMenu.tsx |
Corrects root-route matching. |
client/src/layout/Sidebar/constants.ts |
Points Home to /. |
client/src/layout/ResponsiveNavBar.tsx |
Updates the logo link. |
client/src/features/login/LoginPage.tsx |
Redirects authenticated users home. |
client/src/features/trainee-profile/profile/components/TraineeProfile.tsx |
Enables routed trainee tabs. |
client/src/features/volunteers/profile/VolunteerProfile.tsx |
Enables routed volunteer tabs. |
client/src/features/organisations/profile/OrganisationProfile.tsx |
Enables routed organisation tabs. |
server-spring/src/main/java/nl/hackyourfuture/dojoserver/slack/SlackNotificationSender.java |
Adds tab-specific Slack links. |
server-spring/src/test/java/nl/hackyourfuture/dojoserver/interaction/VolunteerInteractionTest.java |
Verifies volunteer interaction links. |
server-spring/src/test/java/nl/hackyourfuture/dojoserver/interaction/OrganisationInteractionTest.java |
Verifies organisation interaction links. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.