Skip to content

[Enhancement] 优化主题包导出对话框的交互#6516

Merged
Glavo merged 1 commit into
HMCL-dev:mainfrom
ToobLac:theme-pack-prompt
Jul 27, 2026
Merged

[Enhancement] 优化主题包导出对话框的交互#6516
Glavo merged 1 commit into
HMCL-dev:mainfrom
ToobLac:theme-pack-prompt

Conversation

@ToobLac

@ToobLac ToobLac commented Jul 27, 2026

Copy link
Copy Markdown
Contributor
  • 三个输入框都将默认填入默认值,而非只作为 prompt text
  • 作者名称默认值首选为游戏账户名称,如果为空再使用用户名

Resolves #6512

@ToobLac
ToobLac marked this pull request as ready for review July 27, 2026 07:12
@github-actions github-actions Bot added the 10+ label Jul 27, 2026
@Glavo

Glavo commented Jul 27, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e64c8fde8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +345 to +347
String accountName = null;
{
var currentAccount = Accounts.getSelectedAccount();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Annotate the nullable account locals

accountName is initialized to null, and currentAccount can be null when no account is selected, but both locals leave nullability implicit inside an @NotNullByDefault class. Mark both declarations with @Nullable so their contracts match the states handled immediately below.

AGENTS.md reference: AGENTS.md:L8-L9

Useful? React with 👍 / 👎.

@Glavo
Glavo merged commit c9fd7c6 into HMCL-dev:main Jul 27, 2026
3 checks passed
@ToobLac
ToobLac deleted the theme-pack-prompt branch July 27, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 保存主题包界面字体图层错误

2 participants