Update the scope of library support#6513
Conversation
|
除了直接写死，也可以考虑预加载加载器列表，并隐藏没有与当前游戏版本匹配的加载器。 |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a74b4bf186
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else if (GameVersionNumber.compare(gameVersion, "1.2.5") <= 0) { | ||
| this.libraries = new InstallerItem[]{game}; | ||
| } else if (GameVersionNumber.compare(gameVersion, "1.5.1") <= 0) { | ||
| this.libraries = new InstallerItem[]{game, legacyfabric, legacyfabricApi}; |
There was a problem hiding this comment.
When loading an existing 1.3–1.5.1 instance that already contains Forge, this branch omits that loader from getLibraries(). InstallerListPage.loadInstance() renders recognized loaders only from this array, while its analyzer fallback explicitly skips every ID recognized by LibraryType.fromPatchId, so the installed Forge entry disappears and the user can no longer update or remove it through this page. Restrict the filtering to installation choices or separately retain recognized loaders that are already installed.
Useful? React with 👍 / 👎.
2 participants
No description provided.