Skip to content

实例列表左侧游戏文件夹列表添加平滑滚动 - #6495

Open
CiiLu wants to merge 1 commit into
HMCL-dev:mainfrom
CiiLu:f
Open

实例列表左侧游戏文件夹列表添加平滑滚动#6495
CiiLu wants to merge 1 commit into
HMCL-dev:mainfrom
CiiLu:f

Conversation

@CiiLu

@CiiLu CiiLu commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the 1+ label Jul 24, 2026
@Glavo

Glavo commented Jul 25, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84f71d74f8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


{
ScrollPane pane = new ScrollPane();
FXUtils.smoothScrolling(pane);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Move smooth-scrolling setup after content initialization

When animations are enabled, FXUtils.smoothScrolling(pane) immediately delegates to ScrollUtils.smoothScroll, which calls scrollPane.getContent().getParent(). The pane's content is not assigned until the later pane.setContent(wrapper), so constructing GameListPage throws a NullPointerException and prevents the instance list from opening. Move this call below setContent or construct the pane with its content.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants