Skip to content

Conversation

@CiiLu
Copy link
Contributor

@CiiLu CiiLu commented Jan 24, 2026

No description provided.

@CiiLu CiiLu force-pushed the 军帐内公瑾智张昭谋奇策频献沙场上太史勇甘宁霸一骑当十千 branch from 9846c3a to 6c9ade6 Compare January 24, 2026 00:27
@Glavo Glavo requested a review from Copilot January 24, 2026 13:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes #5294 where the Microsoft login details area could render empty when the build does not include a Microsoft OAuth App client id.

Changes:

  • Adds the Microsoft details pane to the container before the “missing client id” early-return, so the warning UI is visible.
  • Disables the “Accept/Login” button when the Microsoft OAuth client id is missing, and resets button disabled state when swapping panes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

} else {
detailsPane = new AccountDetailsInputPane(factory, btnAccept::fire);
btnAccept.disableProperty().bind(((AccountDetailsInputPane) detailsPane).validProperty().not());
}
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initDetailsPane() no longer adds detailsPane to detailsContainer for non-Microsoft factories. The only remaining detailsContainer.getChildren().add(detailsPane) call is inside the Microsoft branch, so selecting any other login method will leave the details area empty.

Suggested fix: re-add detailsPane to detailsContainer in the else branch (after creating/binding AccountDetailsInputPane), or restore a single add-at-end with a guard to avoid double-adding while still handling the early-return case for missing Microsoft clientId.

Suggested change
}
}
if (detailsPane != null && !detailsContainer.getChildren().contains(detailsPane)) {
detailsContainer.getChildren().add(detailsPane);
}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant