Fix joining path same pt Id #3532
Draft
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Screen.Recording.2025-12-26.at.9.08.30.PM.movthere was this issue too. |
0HyperCube
reviewed
Dec 26, 2025
Comment on lines
+473
to
+474
| let start_point = resolve_id(layer1, start_point, 0); | ||
| let end_point = resolve_id(layer2, end_point, 1); |
Contributor
There was a problem hiding this comment.
Only ids in layer2 will change (since the layer1 will probably have no conflicts).
Furthermore it is possible that there is no conflict, in which case the original PointId must be used (like before this PR). You therefore need to check if there was some conflict by checking all of the point ids in the first path.
I don't care if this doesn't work for tables with several vector data, since I find them annoying.
Contributor
|
@Annonnymmousss The issue in your video is the exact same as described in #3519 (the conflicting |
Contributor
Author
|
working on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
im still not getting how to create a segment in the first cmd + J only which is merging the layer but this issue is resolved..
Screen.Recording.2025-12-26.at.9.05.20.PM.mov
solving #3519