Skip to content

Add alpha to Extract Channel node and remove Extract Alpha node#1731

Merged
Keavon merged 4 commits into
GraphiteEditor:masterfrom
skoriop:remove-extract-alpha-node
Apr 17, 2024
Merged

Add alpha to Extract Channel node and remove Extract Alpha node#1731
Keavon merged 4 commits into
GraphiteEditor:masterfrom
skoriop:remove-extract-alpha-node

Conversation

@skoriop

@skoriop skoriop commented Apr 15, 2024

Copy link
Copy Markdown
Contributor

From #code-todo-list (link):

ExtractAlphaNode shouldn't exist, it should be combined into ExtractChannelNode

@skoriop skoriop marked this pull request as ready for review April 15, 2024 21:24
@Keavon

Keavon commented Apr 17, 2024

Copy link
Copy Markdown
Member

!build

@github-actions

Copy link
Copy Markdown
📦 Build Complete for fa5a2f8
https://20755149.graphite.pages.dev

@Keavon Keavon changed the title Remove ExtractAlphaNode Remove Extract Alpha node and add alpha to Extract Channel node Apr 17, 2024
@Keavon Keavon changed the title Remove Extract Alpha node and add alpha to Extract Channel node Add alpha to Extract Channel node and remove Extract Alpha node Apr 17, 2024
@Keavon Keavon merged commit 3019cc7 into GraphiteEditor:master Apr 17, 2024
adamgerhant pushed a commit to adamgerhant/Graphite that referenced this pull request Apr 19, 2024
…hiteEditor#1731)

* add `TaggedValue::RedGreenBlueAlpha`

* add alpha to `ExtractChannelNode`

* remove `ExtractAlphaNode` from `Split Channels`

* remove `ExtractAlphaNode`
@Keavon

Keavon commented Jun 13, 2026

Copy link
Copy Markdown
Member

Hi @skoriop, thanks again for this code contribution to the project! We're still hoping you will respond to the request to relicense this code. Please see #4208 ASAP, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants