Reimplement Brightness/Contrast node using the Curves node to reduce code#1434
Conversation
f7f5beb to
c4bea2b
Compare
|
@Keavon I ran |
|
Great thanks @0HyperCube for the review! It looks like the pull request step is failing in the Github Actions related to the Build Graphite Web step. Is there something else that I need to here? Thanks! For context here is part of the error message: |
|
As long as you've run the tests which your code influences, you're good. There are other tests in our CI pipeline that are currently failing after we decided to merge a giant refactor before we could fix its tests (not usually desired, but it was needed in this case). |
|
Hi @jafriyie1, thanks again for this code contribution to the project! We're still hoping you will respond to the request to relicense this code. Please see #4208 ASAP, thank you! |
Closes #1387