Conversation
0HyperCube
reviewed
Aug 24, 2023
0HyperCube
left a comment
0HyperCube
left a comment
Contributor
There was a problem hiding this comment.
Looks good - just some minor queries.
Keavon
changed the title
Contributor
Author
|
Should be all fixed now :) |
Contributor
|
The "Not" node has, in the properties "Operand B" where there should be nothing. |
Keavon
force-pushed
the
master
branch
16 times, most recently
from
5328ea5 to
52b6a8d
Compare
Keavon
force-pushed
the
master
branch
9 times, most recently
from
a0bf5c4 to
5944186
Compare
Adds OR AND XOR and NOT operators
Inputs to the 'Min' 'Max' 'Equality' and boolean operations nodes were previously named 'First' and 'Second' and are now called 'Operand A' and 'Operand B'
Keavon
approved these changes
Aug 30, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds these boolean operator nodes: