Bezier-rs: Add lookup table function for subpath and make it support euclidean parameterization#1082
Merged
Conversation
linda-zheng
requested review from
Androxium,
RobNadal,
hannahli2010 and
jackiechen73
Androxium
approved these changes
Mar 17, 2023
Androxium
left a comment
Androxium
left a comment
Contributor
There was a problem hiding this comment.
LTGM. Something to keep in mind for the future would be figuring out more efficient ways to compute the euclidean lookup table for a curve as the performance drop on the interactive website when manipulating an example in parametric mode vs. euclidean is quite noticeable.
Deploying with
|
| Latest commit: |
ad2b0f6
|
| Status: | ⚡️ Build in progress... |
Keavon
previously approved these changes
Mar 21, 2023
Member
|
Now that #1085 is merged, there are some breakages when you run the site. |
hannahli2010
force-pushed
the
euclidean-lut
branch
from
2127969 to
53ef950
Compare
Keavon
approved these changes
Mar 28, 2023
Keavon
changed the title
Keavon
added a commit
that referenced
this pull request
Jul 30, 2023
…euclidean parameterization (#1082) * Add euclidean option for lut * Add lut for subpath * Fix rust formatting * Fixed breakages caused by UI updates * Code cleanup * Make ProjectionOptions optional --------- Co-authored-by: Rob Nadal <robnadal44@gmail.com> Co-authored-by: Keavon Chambers <keavon@keavon.com>
Member
|
Hi @linda-zheng, thanks again for this code contribution to the project! We're still hoping you will respond to the request to relicense this code. Please see #4208 ASAP, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
compute_lookup_tableto subpath class.Added
tvalue_type: Option<TValueType>tocompute_lookup_tablein both bezier and subpath classes which allows computation based on euclidean distances rather than parametric.