Fix crash when scaling something with 0 width or height#1078
Merged
Conversation
Deploying with
|
| Latest commit: |
0819537
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://53490405.graphite.pages.dev |
| Branch Preview URL: | https://zero-scale-error.graphite.pages.dev |
Keavon
changed the title
Member
|
One UX nitpick is that the properties panel keeps (displays) the nonzero value typed by the user, even though value remains zero. This gets reset back to 0 properly after the user refreshes the UI by switching to another selected layer and back. But we can fix that at another time. |
Keavon
added a commit
that referenced
this pull request
Jul 30, 2023
* resolve NaN value when trying to change scale value from zero to other numbers * resolve NaN value when trying to change scale value from zero to other numbers --------- Co-authored-by: Keavon Chambers <keavon@keavon.com>
Member
|
Hi @Sahra-Zhou, thanks again for this code contribution to the project! We're still hoping you will respond to the request to relicense this code. Please see #4208 ASAP, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoided the crash and resolved NaN present in property panel when trying to change zero scale to some other value.
Closes #1043