feat: add shift acknowledgement on apply - #556
Conversation
|
Nice feature — the acknowledgement modal is a good upgrade over the plain confirm alert. One thing to fix before this merges though: It silently breaks two tests. Could you update those two tests in this PR to drive the new flow — open the modal, tick the "I acknowledge…" checkbox, then press "Acknowledge & Apply"? The merge is otherwise clean and Non-blocking, but worth a follow-up: the acknowledgement + signature are saved to AsyncStorage only, never sent to the backend. Since this is meant as a shift acknowledgement (potentially a compliance record), it isn't verifiable server-side — worth a ticket for a backend endpoint to persist it. A test for the new Once the two ShiftsScreen tests are updated, this is good to go. 👍 |
|
Thanks for the feedback! I’ve updated the two ShiftsScreen tests to use the new acknowledgement flow by opening the modal, selecting the acknowledgement checkbox, and pressing “Acknowledge & Apply”. I also ran the ShiftsScreen test suite locally and all 4/4 tests are passing now. The changes have been pushed to this PR. |
Summary
Implements GA-043 Shift Acknowledgement for the Guard App.
Changes
Testing