Skip to content

Conversation

@cwangVT
Copy link
Contributor

@cwangVT cwangVT commented Jan 3, 2026

Fixes hashicorp/terraform-provider-google#25664

Cgroup mode v1 is removed after 1.35. Update the test to validate the block of this configuration.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 3, 2026
@github-actions github-actions bot requested a review from roaks3 January 3, 2026 08:15
@github-actions
Copy link

github-actions bot commented Jan 3, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/container and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 6, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 1 file changed, 3 insertions(+), 18 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 270
Passed tests: 254
Skipped tests: 11
Affected tests: 5

Click here to see the affected service packages
  • container

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_networkPerformanceConfig
  • TestAccContainerCluster_withNodeConfigLinuxNodeConfig
  • TestAccContainerCluster_withTPUConfig
  • TestAccContainerCluster_withTpu
  • TestAccContainerNodePool_secondaryBootDisks

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_withNodeConfigLinuxNodeConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_networkPerformanceConfig [Error message] [Debug log]
TestAccContainerCluster_withTPUConfig [Error message] [Debug log]
TestAccContainerCluster_withTpu [Error message] [Debug log]
TestAccContainerNodePool_secondaryBootDisks [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are unrelated to the change

@roaks3 roaks3 added this pull request to the merge queue Jan 6, 2026
Merged via the queue into GoogleCloudPlatform:main with commit c9e35ee Jan 6, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccContainerCluster_withNodeConfigLinuxNodeConfig

3 participants