Skip to content

feat(cloudrun): upgrade helloworld sample to java 25 #10222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alarconesparza wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −7
Draft

feat(cloudrun): upgrade helloworld sample to java 25 #10222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions run/helloworld/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# [START cloudrun_helloworld_dockerfile]
# Use the official maven image to create a build artifact.
# https://hub.docker.com/_/maven
FROM maven:3-eclipse-temurin-17-alpine as builder
FROM maven:3-eclipse-temurin-25-alpine as builder
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Docker base image maven:3-eclipse-temurin-25-alpine does not appear to be publicly available on Docker Hub. This will cause the Docker build to fail. Please use a valid, existing image tag.


# Copy local code to the container image.
WORKDIR /app
Expand All @@ -27,7 +27,7 @@ RUN mvn package -DskipTests

# Use Eclipse Temurin for base image.
# https://docs.docker.com/develop/develop-images/multistage-build/#use-multi-stage-builds
FROM eclipse-temurin:17.0.16_8-jre-alpine
FROM eclipse-temurin:25.0.1_8-jre-alpine
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Docker base image eclipse-temurin:25.0.1_8-jre-alpine does not appear to be publicly available on Docker Hub. This will cause the Docker build to fail. Please use a valid, existing image tag.


# Copy the jar to the production image from the builder stage.
COPY --from=builder /app/target/helloworld-*.jar /helloworld.jar
Expand Down
15 changes: 10 additions & 5 deletions run/helloworld/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ limitations under the License.
<parent>
<groupId>com.google.cloud.samples</groupId>
<artifactId>shared-configuration</artifactId>
<version>1.2.0</version>
<version>1.2.2</version>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The parent POM version 1.2.2 for com.google.cloud.samples:shared-configuration is not available in Maven Central (the latest public version is 1.2.0). Using a non-existent version will cause the build to fail.

</parent>
<dependencyManagement>
<dependencies>
Expand All @@ -41,9 +41,9 @@ limitations under the License.
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<maven.compiler.target>17</maven.compiler.target>
<maven.compiler.source>17</maven.compiler.source>
<spring-boot.version>3.2.2</spring-boot.version>
<maven.compiler.target>25</maven.compiler.target>
<maven.compiler.source>25</maven.compiler.source>
<spring-boot.version>3.5.9</spring-boot.version>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The Spring Boot version 3.5.9 is not a public release and is not available in Maven Central. This will cause dependency resolution to fail during the build.

</properties>
<dependencies>
<dependency>
Expand Down Expand Up @@ -84,14 +84,19 @@ limitations under the License.
<plugin>
<groupId>com.google.cloud.tools</groupId>
<artifactId>jib-maven-plugin</artifactId>
<version>3.4.0</version>
<version>3.5.1</version>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The jib-maven-plugin version 3.5.1 is not available in Maven Central, which will cause the build to fail. The latest public version is 3.4.3.

Suggested change
<version>3.5.1</version>
<version>3.4.3</version>

<configuration>
<to>
<image>gcr.io/PROJECT_ID/helloworld</image>
</to>
</configuration>
</plugin>
<!-- [END cloudrun_helloworld_jib] -->
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<version>0.8.14</version>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The jacoco-maven-plugin version 0.8.14 is not available in Maven Central, which will cause the build to fail. The latest public version is 0.8.12.

Suggested change
<version>0.8.14</version>
<version>0.8.12</version>

</plugin>
</plugins>
</build>
</project>