fix: docker makefile recipies and pre-commit configuration#12
Merged
Conversation
Contributor
efcaguab
commented
Dec 18, 2025
efcaguab
commented
- Improve dependencies of docker recopies in Makefile (prevents need to manually create volume)
- Fix pre-commit dependencies to include codespell
- Add docker-volume dependency to docker-compose recipes - Add codespell[toml]>=2.4 to pre-commit dependencies - Add PYTHON and PIP variables to Makefile for flexibility
There was a problem hiding this comment.
Pull request overview
This PR improves the Makefile and pre-commit configuration by automating docker volume creation and fixing codespell dependencies. The changes make docker-based workflows more robust by automatically creating required external volumes, and ensure codespell is properly available in pre-commit hooks. Additionally, the Makefile is refactored to use centralized PYTHON and PIP variables for better maintainability.
Key Changes:
- Added
docker-volumeas a prerequisite to docker-related targets to automatically create the external GCP volume - Introduced PYTHON and PIP variables to centralize Python command invocations throughout the Makefile
- Added codespell[toml]>=2.4 to pre-commit hook's additional_dependencies
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Makefile | Added PYTHON/PIP variables, made docker targets depend on docker-volume, standardized Python command usage |
| .pre-commit-config.yaml | Added codespell[toml]>=2.4 to additional_dependencies for the codespell hook |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tomaslink
reviewed
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.