PIPELINE-2662: Add basic repository structure#1
Conversation
4c48cf7 to
a12e2d6
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
a12e2d6 to
8d17503
Compare
fb5a7d2 to
bde4d99
Compare
bde4d99 to
b69d245
Compare
73496c3 to
bda0155
Compare
bda0155 to
cdf2dd2
Compare
13dedae to
40076db
Compare
84b7c68 to
8683d22
Compare
8683d22 to
0ab92a3
Compare
rdgfuentes
left a comment
There was a problem hiding this comment.
LGTM. The only comment/doubt I have is about the complexity of this, I'd recommend to validate that with actual end users of this and demo/walk thru the process we aim them to follow when using this template to create a new project and gather their feedback.
e6d2422 to
4e934ac
Compare
I agree. But the first users of this template are us :). So, it should have everything we need, without making the workflow too rigid. For that I documented the pre-commit hooks as optional. Once we merge this basic structure I would have a meeting with research and gather feedback. Then we can add extra things, like a CLI application structure. |
|
@tomaslink The only feedback I have here is what we already discussed in the meeting with Jenn and Anna last week: We need to make it a lot more prevalent in the docs which things are optional and which things aren't depending on who's using this. Pytest is not required for researchers working on POC stuff. Code quality stuff in general is optional, which means most likely everything related to github actions won't be used on POCs. Commit hooks is something you only want to enable when you are dealing with a production repository. Not sure how you want to document that here, but it needs to be clearer. |
@andres-arana pytest does no harm. If you don't have tests, the CI will just run fine, it will not block the workflow of researchers. I don't think we need to disable tests in the CI. It is better to have everything configured and prepared for whenever you add tests. Did you meant that or just documenting that creating tests is optional? The same goes for PEP8 check, in that case it will fail, but can merge it anyways bypassing the rules...So it will not block the workflow. Even better, you already will have information about the status of the repository. One of the goals of the template is not having to re-do stuff, boilerplate configuration in every repository. Again, did you meant to remove PEP8 check from CI or document that failing of PEP8 check can be ignored? Even more, the CI jobs will not be enforced in a PR for merging unless you configure the repo to do so. That's another step we need to document.... The pre-commit quality checks: it is documented that the step for installing pre-commit hooks is optional. Do you think that is not clear enough? Did you read the whole README and Preparing the environment section? |
6bffe5e to
6bc58e9
Compare
smpiano
left a comment
There was a problem hiding this comment.
LGTM. Meet with Tom and Andres to review.
6862e30 to
d60d46b
Compare
Features:
https://globalfishingwatch.atlassian.net/browse/PIPELINE-2662