Skip to content

CORS is wide open on the server with no origin restrictions #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ghvstcode wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CORS is wide open on the server with no origin restrictions #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions server/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Hono } from "hono";
import { cors } from "hono/cors";
Copy link
Copy Markdown
Owner Author

@Ghvstcode Ghvstcode Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

Copy link
Copy Markdown
Owner Author

@Ghvstcode Ghvstcode Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback!

import { logger } from "hono/logger";
import type { Bindings } from "./lib/config.js";
import { auth } from "./routes/auth.js";
Expand All @@ -9,7 +8,6 @@ import { metrics } from "./routes/metrics.js";
const app = new Hono<{ Bindings: Bindings }>();

app.use("*", logger());
app.use("*", cors());
Copy link
Copy Markdown
Owner Author

@Ghvstcode Ghvstcode Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes no sense? we are just removing CORS instead of whityelisting the URLS?

Copy link
Copy Markdown
Owner Author

@Ghvstcode Ghvstcode Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point


app.route("/", auth);
app.route("/", health);
Expand Down
Loading