fix: read MCP server version from package.json and update CLAUDE.md#3
Open
GhadiSaab wants to merge 3 commits into
Open
fix: read MCP server version from package.json and update CLAUDE.md#3GhadiSaab wants to merge 3 commits into
GhadiSaab wants to merge 3 commits into
Conversation
- Add npm run build step to verify TypeScript compiles - Add npm run lint step (eslint --max-warnings 0) - Install eslint and @typescript-eslint as dev dependencies - Add eslint.config.js with TypeScript support - Clean up pre-existing unused variable warnings so CI passes green
- Enhance .gitignore with coverage, IDE, OS, env, log, and temp sections - Add bug report issue template with environment checklist - Add feature request issue template - Add PR template with testing and architecture checklist
- Remove hardcoded version "1.0.0" in MCP server; read from package.json at startup - Update stale Phase 2 text in CLAUDE.md to reflect Phase 1 completion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small fixes:
MCP server version — removed hardcoded
"1.0.0"insrc/mcp/index.ts; now readspkg.versionfrompackage.jsonat startup (currently1.0.4).CLAUDE.md — replaced stale Phase 2 placeholder text with Phase 1 completion status. All 19 steps are implemented and validated; the doc still listed Phase 2 tasks (shell wrappers, CLI wizard, hook plugins) as future work when they're already done.
Files changed
src/mcp/index.ts— added dynamic package.json read, version now matchespackage.jsonCLAUDE.md— Phase 2 → Phase 1 complete, validation gates marked as met