Update ringing config usage docs#1625
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
WalkthroughThe changes add ringing sound muting configuration to the Stream Video SDK. A new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/sounds/RingingConfig.kt (1)
172-172: Minor: Extra blank line after KDoc.There's an extra blank line between the KDoc and the function declaration that differs from the other factory functions in this file. Consider removing for consistency.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/sounds/RingingConfig.kt` at line 172, Remove the extra blank line between the KDoc and the function declaration for the RingingConfig factory so it matches the other factory functions; locate the KDoc immediately above the RingingConfig factory function (e.g., the companion/factory function named like "RingingConfig" or "ringingConfig") and delete the single blank line so the KDoc is directly adjacent to the function declaration.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/sounds/RingingConfig.kt`:
- Line 172: Remove the extra blank line between the KDoc and the function
declaration for the RingingConfig factory so it matches the other factory
functions; locate the KDoc immediately above the RingingConfig factory function
(e.g., the companion/factory function named like "RingingConfig" or
"ringingConfig") and delete the single blank line so the KDoc is directly
adjacent to the function declaration.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: b62e36eb-424a-48aa-917c-d3fb125d94c7
📒 Files selected for processing (2)
stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/StreamVideoBuilder.ktstream-video-android-core/src/main/kotlin/io/getstream/video/android/core/sounds/RingingConfig.kt
SDK Size Comparison 📏
|
|
|
🚀 Available in v1.20.1 |



Goal
Update ringing config usage docs
Implementation
None
🎨 UI Changes
None
Testing
None
Summary by CodeRabbit
New Features
Documentation