Skip to content

Update ringing config usage docs#1625

Merged
aleksandar-apostolov merged 1 commit intodevelopfrom
docs/rahullohra/ringing-config-1
Mar 10, 2026
Merged

Update ringing config usage docs#1625
aleksandar-apostolov merged 1 commit intodevelopfrom
docs/rahullohra/ringing-config-1

Conversation

@rahul-lohra
Copy link
Contributor

@rahul-lohra rahul-lohra commented Mar 6, 2026

Goal

Update ringing config usage docs

Implementation

None

🎨 UI Changes

None

Testing

None

Summary by CodeRabbit

  • New Features

    • Added configuration options to control ringing sounds when the device is muted, with separate toggles for incoming and outgoing call behavior.
  • Documentation

    • Updated documentation references for ringing configuration clarity.

@rahul-lohra rahul-lohra self-assigned this Mar 6, 2026
@rahul-lohra rahul-lohra requested a review from a team as a code owner March 6, 2026 10:22
@rahul-lohra rahul-lohra added the pr:documentation Changes to documentation only label Mar 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@rahul-lohra rahul-lohra changed the title docs: Update ringing config usage docs [AND-1104] Update ringing config usage docs Mar 6, 2026
@rahul-lohra rahul-lohra changed the title [AND-1104] Update ringing config usage docs Update ringing config usage docs Mar 6, 2026
@rahul-lohra rahul-lohra changed the title Update ringing config usage docs [AND-1104] Update ringing config usage docs Mar 6, 2026
@rahul-lohra rahul-lohra changed the title [AND-1104] Update ringing config usage docs Update ringing config usage docs Mar 6, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

Walkthrough

The changes add ringing sound muting configuration to the Stream Video SDK. A new MutedRingingConfig interface with two Boolean properties controls sound playback when the device is muted, alongside a factory function for default configuration. Documentation references were also updated for clarity.

Changes

Cohort / File(s) Summary
Documentation Updates
stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/StreamVideoBuilder.kt
Updated @property sounds Javadoc to reference specific RingingConfig class path instead of generic Sounds reference.
Ringing Mute Configuration
stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/sounds/RingingConfig.kt
Introduced new public interface MutedRingingConfig with playIncomingSoundIfMuted and playOutgoingSoundIfMuted Boolean flags. Added defaultMutedRingingConfig() factory function with default parameters. Updated documentation across factory functions for consistency.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A new config hops into sight,
To mute or not when ringers chime,
Boolean flags dance left and right,
Documentation now reads just fine! 📞✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is severely incomplete, missing most required sections including detailed Goal, Implementation details, and proper contributor/reviewer checklists. Complete the description with detailed Goal explaining why docs needed updating, Implementation describing what was changed, and fill out the contributor and reviewer checklists appropriately.
Title check ❓ Inconclusive The title 'docs: Update ringing config usage docs' is vague and generic, using non-descriptive language that doesn't convey meaningful information about the actual changes made. Consider a more specific title that reflects the actual changes, such as 'docs: Add MutedRingingConfig documentation' or 'feat: Add MutedRingingConfig interface and factory function' since the changes include a new public interface and factory function, not just documentation updates.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch docs/rahullohra/ringing-config-1

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/sounds/RingingConfig.kt (1)

172-172: Minor: Extra blank line after KDoc.

There's an extra blank line between the KDoc and the function declaration that differs from the other factory functions in this file. Consider removing for consistency.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/sounds/RingingConfig.kt`
at line 172, Remove the extra blank line between the KDoc and the function
declaration for the RingingConfig factory so it matches the other factory
functions; locate the KDoc immediately above the RingingConfig factory function
(e.g., the companion/factory function named like "RingingConfig" or
"ringingConfig") and delete the single blank line so the KDoc is directly
adjacent to the function declaration.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/sounds/RingingConfig.kt`:
- Line 172: Remove the extra blank line between the KDoc and the function
declaration for the RingingConfig factory so it matches the other factory
functions; locate the KDoc immediately above the RingingConfig factory function
(e.g., the companion/factory function named like "RingingConfig" or
"ringingConfig") and delete the single blank line so the KDoc is directly
adjacent to the function declaration.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b62e36eb-424a-48aa-917c-d3fb125d94c7

📥 Commits

Reviewing files that changed from the base of the PR and between 94feaea and 111fc7e.

📒 Files selected for processing (2)
  • stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/StreamVideoBuilder.kt
  • stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/sounds/RingingConfig.kt

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 12.00 MB 12.00 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.68 MB 5.68 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.27 MB 6.27 MB 0.00 MB 🟢

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

@aleksandar-apostolov aleksandar-apostolov merged commit 839995a into develop Mar 10, 2026
14 of 16 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the docs/rahullohra/ringing-config-1 branch March 10, 2026 19:41
@stream-public-bot stream-public-bot added the released Included in a release label Mar 10, 2026
@stream-public-bot
Copy link
Collaborator

🚀 Available in v1.20.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:documentation Changes to documentation only released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants