chore(samples): macos builds - #2865
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change centralizes credential persistence checks and excludes macOS. It also updates macOS Flutter configuration, links the generated Swift package, removes the CocoaPods resource-copy phase, and prepares Flutter before builds. ChangesCredential persistence policy
macOS Flutter build integration
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant RunnerScheme
participant macos_assemble.sh
participant FlutterGeneratedPluginSwiftPackage
RunnerScheme->>macos_assemble.sh: Run prepare before build
macos_assemble.sh->>FlutterGeneratedPluginSwiftPackage: Prepare generated package
RunnerScheme->>FlutterGeneratedPluginSwiftPackage: Link package product
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
xsahil03x
reviewed
Aug 4, 2026
| import 'package:stream_chat_flutter/stream_chat_flutter.dart' hide PushProvider; | ||
| import 'package:stream_chat_persistence/stream_chat_persistence.dart'; | ||
|
|
||
| bool get platformSupportsPersistenceCredentials => !CurrentPlatform.isWeb && !CurrentPlatform.isMacOS; |
Member
There was a problem hiding this comment.
But the package mentions MacOs as supported
https://pub.dev/packages/flutter_secure_storage
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@sample_app/lib/auth/auth_controller.dart`:
- Around line 13-14: Update tryAutoConnect() and debugReset() to use
platformSupportsPersistenceCredentials as the guard before reading or deleting
kStreamApiKey, kStreamUserId, and kStreamToken. Replace the web-only check in
tryAutoConnect() and apply the same shared guard to debugReset(), ensuring
unsupported macOS and web platforms never access these credentials.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1358ef21-1165-43ee-adb3-2858c76284be
📒 Files selected for processing (5)
sample_app/lib/auth/auth_controller.dartsample_app/macos/Flutter/Flutter-Debug.xcconfigsample_app/macos/Flutter/Flutter-Release.xcconfigsample_app/macos/Runner.xcodeproj/project.pbxprojsample_app/macos/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
xsahil03x
approved these changes
Aug 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2865 +/- ##
=======================================
Coverage 72.87% 72.87%
=======================================
Files 429 429
Lines 27716 27716
=======================================
Hits 20199 20199
Misses 7517 7517 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submit a pull request
Github Issue: related to #2862
CLA
Description of the pull request
The macos project files were a bit outdated. Also it is a bit tricky to use keychain storage on development builds, so I would just disable that for the sample app.
Summary by CodeRabbit
Bug Fixes
Build & Platform Updates