Skip to content

fix(ui): Message actions background - #2860

Merged
renefloor merged 1 commit into
masterfrom
fix/message-actions-background
Aug 5, 2026
Merged

fix(ui): Message actions background#2860
renefloor merged 1 commit into
masterfrom
fix/message-actions-background

Conversation

@renefloor

@renefloor renefloor commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Submit a pull request

Linear: fixes FLU-645
Linear: fixes FLU-646

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

The mention in notion was wrong, it should not be overlay, but scrim. That's also what's in Figma.

Might be better to merge together with a fix for FLU-647 as this seems to make the issue worse.

Screenshots / Videos

Light:

Before After
image image
image image

Dark:

Before After
image image
image image

Summary by CodeRabbit

Summary by CodeRabbit

  • Bug Fixes

    • Updated modal dialogs to use the design system’s scrim color, improving their appearance in light theme.
  • Documentation

    • Added guidance for interpreting local golden-test failures and platform-specific rendering differences.
    • Documented workflows for comparing test runs and regenerating committed golden files through CI.
    • Added a changelog entry for the modal scrim color update.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4cc07fd6-7b9e-4a24-beae-b98230b555fc

📥 Commits

Reviewing files that changed from the base of the PR and between 252a472 and 13c8b35.

📒 Files selected for processing (3)
  • TESTING.md
  • packages/stream_chat_flutter/CHANGELOG.md
  • packages/stream_chat_flutter/lib/src/misc/stream_modal.dart
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/stream_chat_flutter/lib/src/misc/stream_modal.dart
  • packages/stream_chat_flutter/CHANGELOG.md

📝 Walkthrough

Walkthrough

The PR documents local and CI golden-test workflows. It also changes the default stream dialog barrier color to backgroundScrim and records the correction in the changelog.

Changes

Golden testing guidance

Layer / File(s) Summary
Golden-test workflow
TESTING.md
Documents local golden comparisons, CI rendering differences, platform-golden gitignore behavior, and regeneration through update_goldens.

Modal scrim behavior

Layer / File(s) Summary
Dialog scrim fallback
packages/stream_chat_flutter/lib/src/misc/stream_modal.dart, packages/stream_chat_flutter/CHANGELOG.md
showStreamDialog defaults to colorScheme.backgroundScrim when no barrierColor is provided. The changelog records the affected confirmation modals.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main UI change: updating the message actions background behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/message-actions-background

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@TESTING.md`:
- Around line 216-222: Update the documented golden baseline workflow in
TESTING.md to explicitly stash the change before the first test run, restore it
with git stash pop before the second run, and include a command that compares
the baseline and regenerated golden directories. Keep the existing test commands
and paths aligned with the two-revision comparison.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6365626d-85d5-493a-bb52-94c8dd461197

📥 Commits

Reviewing files that changed from the base of the PR and between a7e26f0 and 634a8e2.

📒 Files selected for processing (3)
  • TESTING.md
  • packages/stream_chat_flutter/CHANGELOG.md
  • packages/stream_chat_flutter/lib/src/misc/stream_modal.dart

Comment thread TESTING.md
Comment on lines +216 to +222
# 1. with your change reverted (git stash), regenerate and keep a copy
GITHUB_ACTIONS=true flutter test --update-goldens
cp -R <goldens/ci dirs> /tmp/baseline/

# 2. restore your change, regenerate again, and diff the two sets
GITHUB_ACTIONS=true flutter test --update-goldens
```

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Make the baseline comparison executable.

Line 216 mentions git stash, but the code block does not run it. Line 220 says to restore the change, but it does not show git stash pop. If readers follow these commands as written, both runs can use the same revision and the comparison cannot isolate the PR change. Add explicit stash, restore, and comparison commands.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@TESTING.md` around lines 216 - 222, Update the documented golden baseline
workflow in TESTING.md to explicitly stash the change before the first test run,
restore it with git stash pop before the second run, and include a command that
compares the baseline and regenerated golden directories. Keep the existing test
commands and paths aligned with the two-revision comparison.

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.87%. Comparing base (252a472) to head (13c8b35).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2860   +/-   ##
=======================================
  Coverage   72.87%   72.87%           
=======================================
  Files         429      429           
  Lines       27716    27716           
=======================================
  Hits        20199    20199           
  Misses       7517     7517           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# Conflicts:
#	packages/stream_chat_flutter/CHANGELOG.md
@renefloor
renefloor force-pushed the fix/message-actions-background branch from 634a8e2 to 13c8b35 Compare August 5, 2026 11:19
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@renefloor
renefloor merged commit b43b0c5 into master Aug 5, 2026
26 of 28 checks passed
@renefloor
renefloor deleted the fix/message-actions-background branch August 5, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants