chore: replace always-on faraday-retry with opt-in RetryConfig#73
Merged
Conversation
The HardDeleteChannels spec waits on an async hard-delete task, but under shared-backend async-queue latency it can miss the 60-attempt poll window and fail. Add an opt-in skip_on_timeout to wait_for_task so the hard-delete example skips rather than fails on timeout, mirroring the getstream-go/php fix; a genuine task failure still returns with status 'failed', and other callers keep the default raise-on-timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://linear.app/stream/issue/CHA-2959/rate-limits-and-retry
Summary
Adds an opt-in auto-retry policy.
RetryConfigis disabled by default (maxAttempts=3,maxBackoff=30s). When enabled, retries ONLYGET/HEADrequests that fail with HTTP 429 or a transport error, honoringRetry-After(clamped tomaxBackoff) otherwise exponential backoff with full jitter. Never retries writes or 5xx; always honors the backendunrecoverableflag; surfaces the last attempt's error. Config surface:retry_config: GetStreamRuby::RetryConfig.new(...)Notes
faraday-retrymiddleware (and its gemspec dependency); retries are now opt-in only.http.request.failedlog event with aretry.attemptfield (transport retries carryerror.type; 429 retries omit it, since that field is the transport-only enum).chore:intentionally so the merge does not auto-publish. Publish later via the manual Release workflow (workflow_dispatch,minor); the release notes should flag the behavior change.