Skip to content

[Fixes #14705] Metadata validation: call validator from admin page - #14710

Open
etj wants to merge 1 commit into
masterfrom
14705_validate_admin
Open

etj wants to merge 1 commit into
masterfrom
14705_validate_admin

Conversation

@etj

@etj etj commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #14705

Port of the 5.1.x work (14705_51x_validate_admin): extracts MetadataValidator out of the validate_metadata management command into geonode/metadata/validation/, adds a validate_metadata admin action (reports outcome as admin messages) and a download_validation_report action (full JSON report, uncapped) on DatasetAdmin, DocumentAdmin, MapAdmin and GeoAppAdmin, plus tests for both the validator and the admin actions. Includes the follow-up fix capping schema-error admin messages and pointing at the download action for the rest, instead of risking an unbounded loop against Django's cookie-based message storage.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

Port of the 5.1.x work (14705_51x_validate_admin): extracts MetadataValidator
out of the validate_metadata management command into geonode/metadata/validation/,
adds a validate_metadata admin action (reports outcome as admin messages) and a
download_validation_report action (full JSON report, uncapped) on DatasetAdmin,
DocumentAdmin, MapAdmin and GeoAppAdmin, plus tests for both the validator and
the admin actions. Includes the follow-up fix capping schema-error admin
messages and pointing at the download action for the rest, instead of risking
an unbounded loop against Django's cookie-based message storage.
@etj etj added this to the 5.1.1 milestone Oct 8, 2026
@etj
etj requested a review from giohappy October 8, 2026 13:35
@etj etj self-assigned this Oct 8, 2026
Copilot AI balanced review requested due to automatic review settings October 8, 2026 13:35
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Oct 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@etj
etj requested review from Gpetrak and removed request for giohappy October 8, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metadata validation: call validator from admin page

2 participants