Skip to content

Improve perf of TextureType.exists #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boubou19 merged 1 commit into from
Jun 1, 2026
Merged

Improve perf of TextureType.exists #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/main/java/com/cricketcraft/chisel/api/rendering/TextureType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.RenderBlocks;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.client.resources.FallbackResourceManager;
import net.minecraft.client.resources.IResourceManager;
import net.minecraft.client.resources.IResourcePack;
import net.minecraft.client.resources.SimpleReloadableResourceManager;
import net.minecraft.launchwrapper.Launch;
import net.minecraft.util.IIcon;
import net.minecraft.util.ResourceLocation;
Expand Down Expand Up @@ -384,11 +388,25 @@ public static TextureType getTypeFor(CarvableHelper inst, String modid, String p
return CUSTOM;
}

// This is ugly, but faster than class.getResource
private static boolean exists(String modid, String path, String postfix) {
ResourceLocation rl = new ResourceLocation(modid, "textures/blocks/" + path + postfix + ".png");

final IResourceManager resMan = Minecraft.getMinecraft().getResourceManager();
if (resMan instanceof SimpleReloadableResourceManager simple) {
FallbackResourceManager fallback = (FallbackResourceManager)simple.domainResourceManagers.get(rl.getResourceDomain());
if (fallback != null) {
for (Object obj : fallback.resourcePacks) {
if (obj instanceof IResourcePack rp && rp.resourceExists(rl)) {
return true;
}
}
return false;
}
}

// Fallback
try {
Minecraft.getMinecraft().getResourceManager().getAllResources(rl);
resMan.getAllResources(rl);
return true;
} catch (Throwable t) {
return false;
Expand Down
4 changes: 4 additions & 0 deletions src/main/resources/META-INF/chisel_compile_at.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@ public net.minecraft.client.renderer.Tessellator field_78417_x

# GUI stuff for item scale
protected net.minecraft.client.gui.inventory.GuiContainer func_146977_a(Lnet/minecraft/inventory/Slot;)V # drawSlot

# Checking if a resource exists
public net.minecraft.client.resources.SimpleReloadableResourceManager field_110548_a # domainResourceManagers
public net.minecraft.client.resources.FallbackResourceManager field_110540_a # resourcePacks