bugfix: allowNonConverged warning instead of aborting#4075
Open
MelReyCG wants to merge 4 commits into
Open
Conversation
…reventing any timestep-cut
…onverged is enabled without preventing timestep-cuts, but at the last level of sub-steps
MelReyCG
requested review from
OmarDuran,
dkachuma,
herve-gross,
jhuang2601 and
rrsettgast
as code owners
MelReyCG
added
ci: run CUDA builds
MelReyCG
changed the title
dkachuma
approved these changes
Jun 4, 2026
| if( m_nonlinearSolverParameters.m_allowNonConverged ) | ||
| { | ||
| GEOS_WARNING_IF( dtRemaining > 0.0 && MpiWrapper::commRank() == 0, | ||
| "Maximum allowed number of sub-steps reached, non-converged solutions are allowed so the simulation continues with innacurate results.", |
Contributor
There was a problem hiding this comment.
Suggested change
| "Maximum allowed number of sub-steps reached, non-converged solutions are allowed so the simulation continues with innacurate results.", | |
| "Maximum allowed number of sub-steps reached but non-converged solutions are allowed so the simulation will continue with potentially inaccurate results.", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When max sub-steps are exceeded and
allowNonConvergedis enabled, the solver now warns (rank 0) and continues instead of aborting (this PR assumesallowNonConvergedwas intended to let the simulation continue even when not converging).