Skip to content

Move triaxial driver#4074

Open
dkachuma wants to merge 6 commits into
developfrom
dkachuma/triaxial-driver
Open

Move triaxial driver#4074
dkachuma wants to merge 6 commits into
developfrom
dkachuma/triaxial-driver

Conversation

@dkachuma
Copy link
Copy Markdown
Contributor

@dkachuma dkachuma commented Jun 3, 2026

Building on the constitutive testing infrastructure established in PR3883, this pull request transitions the TriaxialDriver to use the same framework.

  • Updates the driver to inherit from ConstitutiveDriver rather than directly from TaskBase.
  • Removes built-in unit testing and baseline comparison capabilities (baseline parameter and text comparison logic), delegating validation to the standard testing infrastructure.
  • Consolidates related XML input files into inputFiles/constitutiveDriver/ and adds new ATS integration tests for various triaxial models (e.g., Delft Egg, Drucker-Prager, Elastic Isotropic, Modified CamClay).
  • Updates the Sphinx documentation for the TriaxialDriver to reflect parameter changes, the removal of the integration testing section, and the new standardized output table format.
  • Removes the standalone testTriaxial C++ executable and legacy .txt baseline files, shifting fully to ATS-based restart and output checks.

@dkachuma dkachuma self-assigned this Jun 3, 2026
@dkachuma dkachuma added type: cleanup / refactor Non-functional change (NFC) ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests changes XML input ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Jun 3, 2026
@dkachuma dkachuma marked this pull request as ready for review June 3, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes XML input ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: cleanup / refactor Non-functional change (NFC)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants